Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use pod conditions to manager endpoint #882

Merged
merged 1 commit into from
Jul 28, 2023
Merged

chore: use pod conditions to manager endpoint #882

merged 1 commit into from
Jul 28, 2023

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jul 27, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 96.87% and project coverage change: +27.16% 🎉

Comparison is base (56bde72) 52.06% compared to head (0d3973c) 79.23%.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #882       +/-   ##
===========================================
+ Coverage   52.06%   79.23%   +27.16%     
===========================================
  Files          67       67               
  Lines        5923     5861       -62     
===========================================
+ Hits         3084     4644     +1560     
+ Misses       2755     1023     -1732     
- Partials       84      194      +110
Files Changed Coverage Δ
controllers/apps/v2alpha2/util.go 75.75% <ø> (+5.25%) ⬆️
controllers/apps/v2alpha2/update_pod_conditions.go 85.52% <94.11%> (+85.52%) ⬆️
apis/apps/v2alpha2/emqx_webhook.go 97.68% <100.00%> (+0.08%) ⬆️
apis/apps/v2alpha2/util.go 75.33% <100.00%> (+3.33%) ⬆️
controllers/apps/v2alpha2/add_svc.go 87.36% <100.00%> (+59.22%) ⬆️
controllers/apps/v2alpha2/status_machine.go 98.00% <100.00%> (+0.66%) ⬆️
controllers/apps/v2alpha2/sync_pods.go 70.96% <100.00%> (+23.87%) ⬆️

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit 7c3199b into emqx:main Jul 28, 2023
@Rory-Z Rory-Z deleted the chore/needless-endpoint branch July 28, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Rory-Z